-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug in PVAssignment: missing abs for dxy #8722
Fix bug in PVAssignment: missing abs for dxy #8722
Conversation
A new Pull Request was created by @arizzi for CMSSW_7_4_X. Fix bug in PVAssignment: missing abs for dxy It involves the following packages: CommonTools/RecoAlgos @cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks. |
@cmsbuild please test |
@cmsbuild please test |
The tests are being triggered in jenkins. |
Here some more number testing also the original version of this PR (i.e. including "OtherDZ") ZH->nunubb high pt preselection (analysis like) VBF Hbb so we can stay with current version because it is considered safer and then fine tune in next released (for example using the unassigned category for stuff that would be "OtherDZ" but with unreasonably high I.P.) |
there was an operator error on my end in running the tests, restarted to run correctly now |
+1 for #8722 17da848 In the tests running, differences in monitored quantities are most visible in min-bias-like events (several similar vertices): fairly rarely the leading vertex changes the downstream effects are then in PF neutrals (slight momentum change) and then more downstream plots. Looking at subleading vertices: the order changes more frequently. I looked manually at larger changes in the score values (stored in value maps) and the ones with changes of more than a few units ("GeV**2") are from cases where there are tracks or clusters of tracks fairly far away (at least 5 cm away from the vertex that had this track counted in the vertex score earlier). |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @ktf, @smuzaffar |
+1 |
Fix bug in PVAssignment: missing abs for dxy
This fixes the bug found by @VinInn of missing abs in PV association
Same as #8721
@davidlange6 @slava77 can we include this in 741 in the shadow of the PF nan fix?